pollinator/consent
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

changed: read integration detail views in one store read #4

Merged
jak merged 2 commits from review/integration-single-read into groups-capabilities 2026-10-20 15:41:38 -04:00
Conversation 0 Commits 2 Files changed 9 +201 -62
jak commented 2026-10-20 14:24:10 -04:00
Owner
Copy link

Adds Groups (every group with access, including access-only groups, ordered by name) to service.IntegrationRegistration, filled inside the existing GetIntegrationRegistration transaction. Adds Service.GetIntegrationRegistration and switches the admin integration detail page and GET /integrations/{name} to that single read. Removes the now-unused Service.ListIntegrationGroups.

Manifest preview/apply is unchanged apart from the exported Catalog() helper. New database and service tests cover the field, including an access-only group, and make test passes.

The store-level ListIntegrationGroups is now only exercised by existing database tests. It could be removed in a follow-up along with those tests.

🤖 Generated with Claude Code

Adds `Groups` (every group with access, including access-only groups, ordered by name) to `service.IntegrationRegistration`, filled inside the existing `GetIntegrationRegistration` transaction. Adds `Service.GetIntegrationRegistration` and switches the admin integration detail page and `GET /integrations/{name}` to that single read. Removes the now-unused `Service.ListIntegrationGroups`. Manifest preview/apply is unchanged apart from the exported `Catalog()` helper. New database and service tests cover the field, including an access-only group, and `make test` passes. The store-level `ListIntegrationGroups` is now only exercised by existing database tests. It could be removed in a follow-up along with those tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) 
The admin integration page and the API's get-integration endpoint each made
several separate reads. The admin page could show a capability catalog and a
group list from different moments.

We added every group with access to the integration, including groups that
grant no capability, to the registration that 'GetIntegrationRegistration'
reads in one transaction. Both views now use that single read through a new
service method, and the service's 'ListIntegrationGroups' was removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The integration registration read now returns every group with access, so
nothing outside the database tests called this method. We pointed those tests
at 'GetIntegrationRegistration' so they keep checking the same behavior.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jak merged commit f23d86a811 into groups-capabilities 2026-10-20 15:41:38 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pollinator/consent!4
No description provided.